Allow both @extension and @grpcExtension extensions in schema validation #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman1309
reviewed
Jul 18, 2024
| */ | ||
| record BazExtensions includes Baz { | ||
| @extension.using = "finder: test" | ||
| @grpcExtension.rpc = "get" |
There was a problem hiding this comment.
what would be the expectation for translating this annotation to proto during migration?
There was a problem hiding this comment.
The proto schema would look something like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To help bridge rest.li with gRpc as part of the gRpc migration, this PR allows @extension and @grpcExtension extensions to co-exist in the same schema. More information can be found in SI-39662.
Tests
I added a unit test to check if @extension and @grpcExtension extensions can co-exist in the same schema. I depend on the previous existing tests to check for backwards compatibility.